Do you like putting your code up for review? Many developers I’ve worked with tell me they don’t. But if criticism is something developers are supposed to welcome, why the negative attitude? Well, my guess is they’ve probably gotten a lot of crummy feedback from cruddy reviewers. I’ve been there, on both sides. I want to share a few ideas and bits of advice I’ve put together from experience. What I’ve found is that the smoothness of a code review is not based entirely on the reviewers’ actions; the review requester can sometimes set themselves up for failure. My tips for both reviewers and review requesters are explained below.